Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chip-tool] Add pairing already-discovered command #24917

Merged
merged 3 commits into from
Feb 9, 2023
Merged

[chip-tool] Add pairing already-discovered command #24917

merged 3 commits into from
Feb 9, 2023

Conversation

yufengwangca
Copy link
Contributor

Since we need to keep the pair by ip address API in SDK to support Java JNI implementation and already shipped Darwin software, we should have some way to exercise this API.

Add 'pairing already-discoverred' command in chip-tool

@pullapprove pullapprove bot requested a review from selissia February 8, 2023 08:55
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

PR #24917: Size comparison from e32359f to 324f52c

Decreases (1 build for cc32xx)
platform target config section e32359f 324f52c change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20130724 20130723 -1 -0.0
Full report (1 build for cc32xx)
platform target config section e32359f 324f52c change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640113 640113 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928401 928401 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 299792 299792 0 0.0
.debug_info 20130724 20130723 -1 -0.0
.debug_line 2649331 2649331 0 0.0
.debug_loc 2785586 2785586 0 0.0
.debug_ranges 280656 280656 0 0.0
.debug_str 2978943 2978943 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105593 105593 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375660 375660 0 0.0
.symtab 255728 255728 0 0.0
.text 532396 532396 0 0.0

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

PR #24917: Size comparison from e32359f to fca0b0f

Increases above 0.2%:

platform target config section e32359f fca0b0f change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20130724 20194648 63924 0.3
.debug_str 2978943 3001804 22861 0.8
Increases (1 build for cc32xx)
platform target config section e32359f fca0b0f change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 640113 640233 120 0.0
.debug_abbrev 928401 928439 38 0.0
.debug_aranges 87336 87352 16 0.0
.debug_frame 299792 299840 48 0.0
.debug_info 20130724 20194648 63924 0.3
.debug_line 2649331 2649781 450 0.0
.debug_loc 2785586 2785870 284 0.0
.debug_ranges 280656 280720 64 0.0
.debug_str 2978943 3001804 22861 0.8
.strtab 375660 375840 180 0.0
.symtab 255728 255856 128 0.1
.text 532396 532524 128 0.0
Decreases (1 build for cc32xx)
platform target config section e32359f fca0b0f change % change
cc32xx lock CC3235SF_LAUNCHXL .rodata 105593 105585 -8 -0.0
Full report (1 build for cc32xx)
platform target config section e32359f fca0b0f change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640113 640233 120 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928401 928439 38 0.0
.debug_aranges 87336 87352 16 0.0
.debug_frame 299792 299840 48 0.0
.debug_info 20130724 20194648 63924 0.3
.debug_line 2649331 2649781 450 0.0
.debug_loc 2785586 2785870 284 0.0
.debug_ranges 280656 280720 64 0.0
.debug_str 2978943 3001804 22861 0.8
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105593 105585 -8 -0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375660 375840 180 0.0
.symtab 255728 255856 128 0.1
.text 532396 532524 128 0.0

@yufengwangca yufengwangca enabled auto-merge (squash) February 9, 2023 03:12
@yufengwangca yufengwangca disabled auto-merge February 9, 2023 05:08
@yufengwangca yufengwangca enabled auto-merge (squash) February 9, 2023 05:08
@yufengwangca yufengwangca merged commit a699913 into project-chip:master Feb 9, 2023
lpbeliveau-silabs pushed a commit to lpbeliveau-silabs/connectedhomeip that referenced this pull request Feb 13, 2023
@yufengwangca @lpbeliveau-silabs
[chip-tool] Add pairing already-discovered command (project-chip#24917)
e26e08e 
* [chip-tool] Add pairing already-discovered command

* Address review comments

* Use PairingNetworkType::None instead of PairingNetworkType::Network
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@yufengwangca
[chip-tool] Add pairing already-discovered command (project-chip#24917)
0f907a3 
* [chip-tool] Add pairing already-discovered command

* Address review comments

* Use PairingNetworkType::None instead of PairingNetworkType::Network
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@andy31415 andy31415 Awaiting requested review from andy31415

Assignees
No one assigned
Labels
examples review - approved tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yufengwangca @andy31415 @bzbarsky-apple